git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [REQUEST 1/1] docs: update http.<url>.* options documentation

From
Kyle J. McKay <mackyle@gmail.com>
Date
Jul 27, 2013, 02:15 UTC
Message-ID
<251106F7-56FA-4503-A4C9-267A5EF04A2C@gmail.com>
In-Reply-To
<20130726222732.GA3444@sigill.intra.peff.net>
On Jul 26, 2013, at 15:27, Jeff King wrote:
Show 50 quoted lines
> On Thu, Jul 25, 2013 at 11:23:23PM -0700, Kyle J. McKay wrote:
>
>>> IMHO, this would be more clear as a single item, like:
>>>
>>> . User name (e.g., `user` in `https://user@example.com/repo.git`).  
>>> If
>>>  the config key has a user name it must match the user name in the
>>>  URL exactly. If the config key does not have a user name, that
>>>  config key will match a URL with any user name (including none).
>>
>> The only problem I have with a single item is what's the precedence?
>> Does an exact user match have the same precedence as an any-user
>> match?  That would seem to be implied by having them as the same item
>> number.  Separating them would appear to make it clearer that an
>> exact user match wins over an any user match, but if you have some
>> alternate text as a suggestion for the single item that clears that
>> up...  :)
>
> Ah, I see your thinking now. You want to say "no username has less
> precedence than some username, which has less precedence than a path",
> so they are all elements of a single list.  My thinking was "username
> has precedence less than path, and like a shorter path has less
> precedence than a longer path, an empty username has less precedence
> than a non-empty username".
>
> I agree my suggested wording would need to mention that explicitly.
> Like:
>
>  . User name (e.g., `user` in `https://user@example.com/repo.git`). If
>    the config key has a user name it must match the user name in the
>    URL exactly. If the config key does not have a user name, that
>    config key will match a URL with any user name (including none),  
> but
>    at lower precedence than a config key with a user name.
>
> I can live with it either way, though. They are just two ways of
> considering the same thing.
>
>> I am considering this text to address that:
>>
>>> All URLs are normalized (%-encodings are standardized, case- 
>>> insensitive
>>> parts are lowercased, `./` and `../` path components are resolved)
>>> before
>>> attempting any matching (the password part, if embedded in the URL,
>>
>> but I'm not sure the extra verbiage makes it better.  I think it may
>> just complicate the explanation unnecessarily?
>
> Yeah, I think I agree. Let's leave it out.

So there's a version of this in next as cea9928 and I think that version is fine. If the documentation gets updated in the future, or perhaps moved to a separate urls-matching.txt for some reason at some point (git config --url, git config --url-parse), I'll make a point of inserting the ", but at lower precedence than a config key with a user name" text.

Kyle
Previous: Jeff KingNext: Jeff King
Message 8 of 11 in “[REQUEST 0/1] Requesting your signed-off-by”
  1. Kyle J. McKayJul 25, 2013
  2. 1/1 docs: update http.<url>.* options documentationKyle J. McKay, Jul 25, 2013
  3. Jeff KingJul 26, 2013
  4. Junio C HamanoJul 26, 2013
  5. Junio C HamanoJul 26, 2013
  6. Kyle J. McKayJul 26, 2013
  7. Jeff KingJul 26, 2013
  8. Kyle J. McKayJul 27, 2013
  9. Jeff KingJul 27, 2013
  10. Kyle J. McKayJul 27, 2013
  11. Kyle J. McKayJul 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.