Re: [PATCH 0/7] A couple of Meson improvements

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Oct 5, 2026, 09:51 UTC
Message-ID: <24737aed-50c5-4536-a081-938036c08588@gmail.com>
In-Reply-To: <20260924-pks-meson-improvements-v1-0-90b7f79f1c4e@pks.im>

On 9/24/26 19:39, Patrick Steinhardt wrote:

Show 7 quoted lines

>
> ---
> Patrick Steinhardt (7):
>        meson: avoid recompiling HTTP sources several times
>        meson: don't recompile git-remote-http(1) multiple times for tests
>        meson: use precompiled headers for our test-helper
>        meson: use precompiled headers for unit tests

The only other sub-directory that does not yet include the precompiled header is 'compat' and leaving it out seems to be the right choice. Including it would trigger recursive compilation issues as git-compat-util.h itself depends on compat/posix.h. Trying to reshuffle the build code to fix this seems not worthwhile given the amount of code is a bit less there.

A few other similar targets that were not touched by this series are non-worthwhile such as 'common-main', 'git-curl' etc.

Apart from the few other comments in other threads, this series looks good to me.

-- 
Sivaraam