Re: [PATCH 2/2] add [--] to usage of filter-branch

From: Andreas Heiduk <asheiduk@gmail.com>
Date: Jun 9, 2017, 14:33 UTC
Message-ID: <243a8308-6696-1494-49e9-ccd01acfaa46@gmail.com>
In-Reply-To: <xmqqk24l717a.fsf@gitster.mtv.corp.google.com>

Am 09.06.2017 um 15:14 schrieb Junio C Hamano:

Show 28 quoted lines

> Andreas Heiduk <asheiduk@gmail.com> writes:
> 
>> Am 03.06.2017 um 12:17 schrieb Andreas Heiduk:
>>> Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>
>>> ---
>>>  Documentation/git-filter-branch.txt | 3 ++-
>>>  git-filter-branch.sh                | 2 +-
>>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
>>> index 45c849d8c..1efdda804 100644
>>> --- a/Documentation/git-filter-branch.txt
>>> +++ b/Documentation/git-filter-branch.txt
>>> @@ -86,7 +86,8 @@ OPTIONS
>>>  	This is not a real filter executed for each commit but a one
>>>  	time setup just before the loop. Therefore no commit-specific
>>>  	variables are defined yet.  Functions or variables defined here
>>> -	can be used or modified in the following filter steps.
>>> +	can be used or modified in the following filter steps except
>>> +	the commit filter, for technical reasons.
>>
>> I'll move that into the previous commit.
> 
> Yeah, the description of "technical limitation" is different from
> clarifying the disambiguating "--" in the documentation.
> 
> I am curious what the "technical reason" really is, though ;-)
>

Well, I just picked up the wording from the "Filter" section a couple paragraphs above:

> The filters are applied in the order as listed below.  The <command>
> argument is always evaluated in the shell context using the 'eval' command
> (with the notable exception of the commit filter, for technical reasons).

Because these reasons exist independently from my change I think I can get away with just that snappy reference :-]