git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

From
Jörn Hees <dev@joernhees.de>
Date
Jul 26, 2013, 12:16 UTC
Message-ID
<2428D514-68F9-43C7-B59D-C316BE03BCAA@joernhees.de>
In-Reply-To
<CAMP44s16bRx0p_F=PTcy9bekg_5TVC_GsQjzOev6xkpCEWcjAw@mail.gmail.com>
On 25 Jul 2013, at 21:12, Felipe Contreras <felipe.contreras@gmail.com> wrote:
Show 28 quoted lines
>> […]
>> ---
>> contrib/remote-helpers/git-remote-hg | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
>> index 0194c67..f4e9d1c 100755
>> --- a/contrib/remote-helpers/git-remote-hg
>> +++ b/contrib/remote-helpers/git-remote-hg
>> @@ -390,7 +390,7 @@ def get_repo(url, alias):
>>         if not os.path.exists(dirname):
>>             os.makedirs(dirname)
>>     else:
>> -        shared_path = os.path.join(gitdir, 'hg')
>> +        shared_path = os.path.join(gitdir, 'hg', '.shared')
>>         if not os.path.exists(shared_path):
>>             try:
>>                 hg.clone(myui, {}, url, shared_path, update=False, pull=True)
>> --
>> 1.8.3.4
> 
> I don't like this approach because if it's a huge repository the user
> would have to clone again, not only if he was using v1.8.3, but also
> if he was using the latest and greatest (because you are changing the
> location again). t's relatively trivial to move from the old to the
> shared organization, so that's what I vote for. Besides, I don't see
> the point of having a '.shared/.hg' directory, and nothing else on
> that '.shared' folder.
Agreed… it just was the shortest possible fix with an in my POV minor optimisation drawback of once refetching...
Previous: Felipe Contreras
Message 16 of 16 in “remotes-hg: bugfix for fetching non local remotes”
  1. remotes-hg: bugfix for fetching non local remotesJoern Hees, Jul 25, 2013
  2. Felipe ContrerasJul 25, 2013
  3. Antoine PelisseJul 25, 2013
  4. Felipe ContrerasJul 25, 2013
  5. Antoine PelisseJul 25, 2013
  6. Junio C HamanoJul 26, 2013
  7. Jörn HeesJul 26, 2013
  8. remote-hg: Fix cloning and sharing bugAntoine Pelisse, Aug 4, 2013
  9. Jörn HeesAug 4, 2013
  10. Felipe ContrerasAug 4, 2013
  11. Jörn HeesAug 4, 2013
  12. Felipe ContrerasAug 4, 2013
  13. Antoine PelisseAug 4, 2013
  14. Felipe ContrerasAug 4, 2013
  15. Felipe ContrerasAug 4, 2013
  16. Jörn HeesJul 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.