Re: What's cooking in git.git (Dec 2021, #03; Fri, 10)

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Dec 13, 2021, 15:32 UTC
Message-ID: <23f0375c-41ab-348f-f11a-161e6514bb9d@jeffhostetler.com>
In-Reply-To: <xmqqilvvluoa.fsf@gitster.g>

On 12/10/21 9:52 PM, Junio C Hamano wrote:

Show 8 quoted lines

> 
> 
> * js/trace2-avoid-recursive-errors (2021-11-18) 1 commit
>    (merged to 'next' on 2021-12-02 at c5b1e5ddec)
>   + trace2: disable tr2_dst before warning on write errors
> 
>   trace2 error code path fix.
>   source: <5a9e49e7f1540d762374382e1769edf112cf093f.1637272706.git.steadmon@google.com>

Sorry, I've been away from the list for a while.

I just noticed this is using "sigchain_push()" which might be called from threaded code and could cause problems.

I think pthread_sigmask() would be a safer choice here.

I documented the reasons in compat/simple-ipc/ipc-unix-socket.c in the header before "thread_block_sigpipe()".

Jeff