Re: [PATCH] Revert "git-svn: Speed up fetch"

From: Mikael Magnusson <mikachu@gmail.com>
Date: Jun 28, 2008, 23:51 UTC
Message-ID: <237967ef0806281651p3abf6ae4j9169cdc5bbf8f85d@mail.gmail.com>
In-Reply-To: <1214686673-28099-1-git-send-email-apenwarr@gmail.com>

2008/6/28 Avery Pennarun <apenwarr@gmail.com>:

Show 13 quoted lines

> This reverts commit ffe256f9bac8a40ff751a9341a5869d98f72c285, because it
> was causing errors of the form:
>
> Checksum mismatch: trunk/.depend 16e748c219f9f95bf3d05c6b2af5444290bc8471
> expected: 05fb5edb8c8057be006c7e913ae0c764
>     got: 763b9a426c5bd61e0a85252459d37cfa
>
> Note that the exact failing file and checksum seems to vary if you clear
> the repository and try again.
>
> Conflicts:
>
>        git-svn.perl

Wasn't this the problem that was fixed by d683a0e00cd4734b4fab704baef1ee76205722be[1]?

-- 
Mikael Magnusson

[1]

commit d683a0e00cd4734b4fab704baef1ee76205722be
Author: Junio C Hamano <gitster@pobox.com>
Date:   Tue May 27 23:33:22 2008 -0700

    Git::cat_blob: allow using an empty blob to fix git-svn breakage

    Recent "git-svn optimization" series introduced Git::cat_blob() subroutine
    whose interface was broken in that it returned the size of the blob but
    signalled an error by returning 0.  You can never use an empty blob with
    such an interface.

    This fixes the interface to return a negative value to signal an error.

    Reported by Björn Steinbrink.

    Signed-off-by: Junio C Hamano <gitster@pobox.com>