Re: What's cooking in git.git (Sep 2024, #01; Tue, 3)

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 4, 2024, 13:38 UTC
Message-ID: <23586012-f3d7-43ba-bec3-9e67808fcbd9@gmail.com>
In-Reply-To: <ZtgBKbEnL8xJBGpE@pks.im>

On 04/09/2024 07:41, Patrick Steinhardt wrote:

Show 25 quoted lines

> On Tue, Sep 03, 2024 at 04:01:31PM -0700, Junio C Hamano wrote:
>> * ps/clar-unit-test (2024-09-03) 14 commits
>>   - clar: add CMake support
>>   - t/unit-tests: convert ctype tests to use clar
>>   - t/unit-tests: convert strvec tests to use clar
>>   - t/unit-tests: implement test driver
>>   - Makefile: wire up the clar unit testing framework
>>   - Makefile: do not use sparse on third-party sources
>>   - Makefile: make hdr-check depend on generated headers
>>   - Makefile: fix sparse dependency on GENERATED_H
>>   - clar: stop including `shellapi.h` unnecessarily
>>   - clar(win32): avoid compile error due to unused `fs_copy()`
>>   - clar: avoid compile error with mingw-w64
>>   - t/clar: fix compatibility with NonStop
>>   - t: import the clar unit testing framework
>>   - t: do not pass GIT_TEST_OPTS to unit tests with prove
>>
>>   Import clar unit tests framework libgit2 folks invented for our
>>   use.
>>
>>   Ready?
>>   source: <cover.1725349234.git.ps@pks.im>
> 
> I'd like to wait for a (hopefully) final review from Phillip before this
> is merged down.

I've just posted a review - it all looks fine apart from the implementation of "--immediate" flag which we could drop until we have a better solution (c.f. <e435e05a-376c-4928-9852-6925df855399@gmail.com>).

Best Wishes

Phillip

> Patrick