git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: grep: fix multibyte regex handling under macOS (1819ad327b7a1f19540a819813b70a0e8a7f798f)

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 3, 2023, 21:56 UTC
Message-ID
<230203.86357mbe8x.gmgdl@evledraar.gmail.com>
In-Reply-To
<Y9098dyaTtiNk506@coredump.intra.peff.net>
On Fri, Feb 03 2023, Jeff King wrote:
Show 17 quoted lines
> On Thu, Feb 02, 2023 at 05:22:37PM +0100, demerphq wrote:
>
>> I've been lurking watching some of the regex discussion on the list
>> and personally I think it is asking for trouble to use "whatever regex
>> engine is traditional in a given environment" instead of just choosing
>> a good open source engine and using it consistently everywhere.  I
>> don't really buy the arguments I have seen to justify a policy of "use
>> the standard library version"; regex engines vary widely in
>> performance and implementation and feature set, and even the really
>> good ones do not entirely agree on every semantic[1], so if you don't
>> standardize you will be forever dealing with bugs related to those
>> differences.
>
> I think this is a perennial question for portable software: is it better
> to be consistent across platforms (by shipping our own regex engine), or
> consistent with other programs on the same platform (by using the system
> regex).
*nod*
Show 5 quoted lines
> I don't have a strong opinion either way. The main concern I'd have is
> handling dependencies. I like pcre a lot, but I'm not sure that I would
> want building Git to require pcre on every platform. If there's an
> engine we can ship as a vendored dependency that builds everywhere, that
> helps.

We can just make that fallback engine be PCRE. I submitted patches a while ago to include a minimal version of it in compat/pcre, as we seem to have some allergy to external dependencies: https://lore.kernel.org/git/20170511175115.648-1-avarab@gmail.com/

It's ~80k lines instead of compat/regex's ~15k, but it's actually maintained, and would be much easier to upgrade.

Previous: Jeff KingNext: Jeff King
Message 13 of 22 in “RE: grep: fix multibyte regex handling under macOS (1819ad327b7a1f19540a819813b70a0e8a7f798f)”
  1. D. Ben KnobleFeb 1, 2023
  2. demerphqFeb 1, 2023
  3. D. Ben KnobleFeb 1, 2023
  4. demerphqFeb 1, 2023
  5. Junio C HamanoFeb 1, 2023
  6. D. Ben KnobleFeb 1, 2023
  7. D. Ben KnobleFeb 1, 2023
  8. Junio C HamanoFeb 1, 2023
  9. Jeff KingFeb 1, 2023
  10. demerphqFeb 2, 2023
  11. D. Ben KnobleFeb 2, 2023
  12. Jeff KingFeb 3, 2023
  13. Ævar Arnfjörð BjarmasonFeb 3, 2023
  14. Jeff KingFeb 4, 2023
  15. demerphqFeb 4, 2023
  16. D. Ben KnobleFeb 5, 2023
  17. Jeff KingFeb 7, 2023
  18. D. Ben KnobleFeb 7, 2023
  19. Jeff KingFeb 7, 2023
  20. D. Ben KnobleFeb 2, 2023
  21. Jeff KingFeb 3, 2023
  22. D. Ben KnobleFeb 3, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.