Re: [PATCH 0/5] cleaning up read_object() family of functions
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jan 12, 2023, 16:22 UTC
- Message-ID
- <230112.86v8lbzpj1.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <Y8AyTE3OS7HCAzKH@coredump.intra.peff.net>
On Thu, Jan 12 2023, Jeff King wrote:
Show 40 quoted lines
> On Thu, Jan 12, 2023 at 10:21:46AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> I agree that it's probably not worth it here, but I think you're just
>> tying yourself in knots in trying to define these macros in terms of
>> each other. This sort of thing will work if you just do:
>>
>> diff --git a/object-store.h b/object-store.h
>> index e894cee61ba..bfcd2482dc5 100644
>> --- a/object-store.h
>> +++ b/object-store.h
>> @@ -418,8 +418,8 @@ struct object_info {
>> * Initializer for a "struct object_info" that wants no items. You may
>> * also memset() the memory to all-zeroes.
>> */
>> -#define OBJECT_INFO(...) { 0, __VA_ARGS__ }
>> -#define OBJECT_INFO_INIT OBJECT_INFO()
>> +#define OBJECT_INFO_INIT { 0 }
>> +#define OBJECT_INFO(...) { __VA_ARGS__ }
>
> Right, that works because the initializer is just "0", which the
> compiler can do for us implicitly. I agree it works here to omit, but as
> a general solution, it doesn't.
>
>> Which is just a twist on René's suggestion from [1], i.e.:
>>
>> #define CHILD_PROCESS_INIT_EX(...) { .args = STRVEC_INIT, __VA_ARGS__ }
>>
>> In that case we always need to rely on the "args" being init'd, and the
>> GCC warning you note is a feature, its initialization is "private", and
>> you should never override it.
>
> Right, and it works here because you'd never want to init .args to
> anything else (which I think is what you mean by "private"). But in the
> general case the defaults can't set something that the caller might want
> to override, because the compiler's warning doesn't know the difference
> between "override" and "oops, you specified this twice".
>
> It's mostly a non-issue because we tend to prefer 0-initialization when
> possible, but I think as a general technique this is probably opening a
> can of worms for little benefit.You're right in the general case, although I think that if we did encounter such a use-case a perfectly good solution would be to just suppress the GCC-specific warning with the relevant GCC-specific macro magic, this being perfectly valid C, just something it (rightly, as it's almost always a mistake) complains about.
But I can't think of a case where this would matter for us in practice.
We have members like "struct strbuf"'s "buf", which always needs to be init'd, but never "maybe by the user", so the pattern above would work there.
Then we have things like "strdup_strings" which we might imagine that the user would override (with a hypothetical "struct string_list" that took more arguments, but in those cases we could just add another init macro, as "STRING_LIST_INIT_{DUP,NODUP}" does.
For any such member we could always just invert its boolean state, if it came to that, couldn't we?
Anyway, I agree that it's not worth pursuing this in this case.
But I think it's a neat pattern that we might find use for sooner than later for something else.
I don't think it's worth the churn to change it at this point (except maybe with a sufficiently clever coccinelle rule), but I think it's already "worth it" in the case of the run-command API, if we were adding that code today under current constraints (i.e. being able to use C99 macro features).