Re: [PATCH 0/5] git check-ref-format --stdin --report-errors

From

IJIan Jackson <ijackson@chiark.greenend.org.uk>

Date

Dec 19, 2016, 16:22 UTC

Message-ID

<22616.2400.364518.636144@chiark.greenend.org.uk>

In-Reply-To

<561c0338-66cd-f806-7b3b-b422f98a1564@alum.mit.edu>

Michael Haggerty writes ("Re: [PATCH 0/5] git check-ref-format --stdin --report-errors"):

> Thanks for your patches. I left some comments about the individual patches.

Thanks for your review.

> I don't know whether this feature will be popular, but it's not a lot of
> code to add it, so it would be OK with me.

Great.

> Especially given that the output is not especially machine-readable, it
> might be more consistent with other commands to call the new feature
> `--verbose` rather than `--report-errors`.

Sure.

> If it is thought likely that scripts will want to leave a pipe open to
> this command and feed it one query at a time, then it would be helpful
> to flush stdout after each reference's result is written. If the
> opposite use case is common (mass processing of refnames), we could
> always add a `--buffer` option like the one that `git cat-file --batch` has.

-- 
Ian Jackson <ijackson@chiark.greenend.org.uk>   These opinions are my own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.