git/list[1] front-page[2] threads[3] people[4] search[5] about
 

built-in-submodule & in-flight dependencies (was: What's cooking in git.git (Dec 2022, #07; Mon, 26))

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 28, 2022, 08:36 UTC
Message-ID
<221228.864jtfvs0q.gmgdl@evledraar.gmail.com>
In-Reply-To
<xmqqcz86n8bn.fsf@gitster.g>
On Mon, Dec 26 2022, Junio C Hamano wrote:
Show 35 quoted lines
> [...]
> [Cooking]
>
> * ab/no-more-git-global-super-prefix (2022-12-26) 9 commits
>  - read-tree: add "--super-prefix" option, eliminate global
>  - submodule--helper: convert "{update,clone}" to their own "--super-prefix"
>  - submodule--helper: convert "status" to its own "--super-prefix"
>  - submodule--helper: convert "sync" to its own "--super-prefix"
>  - submodule--helper: convert "foreach" to its own "--super-prefix"
>  - submodule--helper: don't use global --super-prefix in "absorbgitdirs"
>  - submodule.c & submodule--helper: pass along "super_prefix" param
>  - read-tree + fetch tests: test failing "--super-prefix" interaction
>  - submodule absorbgitdirs tests: add missing "Migrating git..." tests
>
>  Stop using "git --super-prefix" and narrow the scope of its use to
>  the submodule--helper.
>
>  Will merge to 'next'.
>  source: <cover-v5-0.9-00000000000-20221220T104519Z-avarab@gmail.com>
> [...]
> * ab/config-multi-and-nonbool (2022-11-27) 9 commits
>  - for-each-repo: with bad config, don't conflate <path> and <cmd>
>  - config API: add "string" version of *_value_multi(), fix segfaults
>  - config API users: test for *_get_value_multi() segfaults
>  - for-each-repo: error on bad --config
>  - config API: have *_multi() return an "int" and take a "dest"
>  - versioncmp.c: refactor config reading next commit
>  - config tests: add "NULL" tests for *_get_value_multi()
>  - config tests: cover blind spots in git_die_config() tests
>  - for-each-repo tests: test bad --config keys
>
>  Assorted config API updates.
>
>  Waiting for review.
>  source: <cover-v3-0.9-00000000000-20221125T093158Z-avarab@gmail.com>

I see that ab/no-more-git-global-super-prefix has landed in "next", I was planning to submit the built-in submodule topic after it, i.e. the change to get rid of git-submodule.sh.

But the post-cleanup in that topic of moving the relevant code from builtin/submodule--helper.c to builtin/submodule.c would conflict with ab/config-multi-and-nonbool, as some of it uses the *_multi() API.

Now, it would be relatively easy to solve those conflicts, but I'd also like to make it easier for you, Junio.

So more reviews on that topic would be most welcome. It fixes quite a few segfaults we currently have in-tree, so I'm a bit surprised at the relative lack of interest.

Previous: Junio C Hamano
Message 6 of 6 in “What's cooking in git.git (Dec 2022, #07; Mon, 26)”
  1. Junio C HamanoDec 26, 2022
  2. cmake topics & js/ci-disable-cmake-by-default (was: What's cooking in git.git (Dec 2022, #07; Mon, 26))Ævar Arnfjörð Bjarmason, Dec 26, 2022
  3. Junio C HamanoDec 27, 2022
  4. Ævar Arnfjörð BjarmasonDec 27, 2022
  5. Junio C HamanoDec 27, 2022
  6. built-in-submodule & in-flight dependencies (was: What's cooking in git.git (Dec 2022, #07; Mon, 26))Ævar Arnfjörð Bjarmason, Dec 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.