git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 6/6] ls-tree: introduce '--pattern' option

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 14, 2022, 10:03 UTC
Message-ID
<221214.86edt247xk.gmgdl@evledraar.gmail.com>
In-Reply-To
<xmqqbko6y2q5.fsf@gitster.g>
On Wed, Dec 14 2022, Junio C Hamano wrote:
Show 23 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>>> The hard-coded object IDs break the `linux-sha256` job, as pointed out in
>>> https://github.com/git/git/blob/6ab7651d8669/whats-cooking.txt#L522-L537.
>>>
>>> Please squash this in to address this (Junio, please feel free to
>>> cherry-pick this on top of `tl/ls-tree--pattern` to reduce the number of
>>> CI failures):
>
> After re-reading the patches, I am very much inclined to drop this
> topic, which does not add much value to the system and adds an odd
> corner case in the UI.
>
> Who needs "git ls-tree --pattern='blob 486' HEAD" that is a synonym
> to "git ls-tree HEAD | grep 'blob 486'"?  Should we end up adding
> the same option to "git ls-files", "git status", "git ls-remote",
> "git remote", "git branch --list", etc. for consistency?
>
> This is simply insane and goes directly against the "one tool does
> one job well, and can be combined with other such tools via pipe",
> which is a key to scale the usability of a set of tools.

I agree, and FWIW I read https://lore.kernel.org/git/20221121114150.3473-1-tenglong.tl@alibaba-inc.com/ as the submitter of the topic agreeing to drop it ~3 weeks ago.

Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 34 in “ls-tree: introduce '--pattern' option”
  1. 0/6 ls-tree: introduce '--pattern' optionTeng Long, Nov 17, 2022
  2. 1/6 ls-tree: cleanup the redundant SPACETeng Long, Nov 17, 2022
  3. 2/6 t3104: remove shift code in 'test_ls_tree_format'Teng Long, Nov 17, 2022
  4. 3/6 ls-tree: optimize params of 'show_tree_common_default_long()'Teng Long, Nov 17, 2022
  5. 4/6 ls-tree: improving cohension in the print codeTeng Long, Nov 17, 2022
  6. Ævar Arnfjörð BjarmasonNov 17, 2022
  7. 5/6 ls-tree: introduce 'match_pattern()' functionTeng Long, Nov 17, 2022
  8. Ævar Arnfjörð BjarmasonNov 17, 2022
  9. Ævar Arnfjörð BjarmasonNov 30, 2022
  10. 6/6 ls-tree: introduce '--pattern' optionTeng Long, Nov 17, 2022
  11. Ævar Arnfjörð BjarmasonNov 17, 2022
  12. Johannes SchindelinDec 12, 2022
  13. Junio C HamanoDec 12, 2022
  14. Junio C HamanoDec 14, 2022
  15. Ævar Arnfjörð BjarmasonDec 14, 2022
  16. Junio C HamanoDec 14, 2022
  17. win-test: unknown terminal "xterm-256color", was Re: [RFC PATCH 6/6] ls-tree: introduce '--pattern' optionJohannes Schindelin, Mar 27, 2023
  18. Junio C HamanoMar 27, 2023
  19. Jeff KingMar 28, 2023
  20. Junio C HamanoMar 28, 2023
  21. Jeff KingMar 28, 2023
  22. Jeff KingMar 28, 2023
  23. Junio C HamanoMar 28, 2023
  24. Ævar Arnfjörð BjarmasonNov 17, 2022
  25. Taylor BlauNov 17, 2022
  26. Teng LongNov 21, 2022
  27. Ævar Arnfjörð BjarmasonNov 21, 2022
  28. 0/4 ls-tree: pass state in struct, not globalsÆvar Arnfjörð Bjarmason, Nov 17, 2022
  29. 1/4 ls-tree: don't use "show_tree_data" for "fast" callbacksÆvar Arnfjörð Bjarmason, Nov 17, 2022
  30. 1/4 ls-tree: don't use "show_tree_data" for "fast" callbacksTeng Long, Dec 21, 2022
  31. 3/4 ls-tree: fold "show_tree_data" into "cb" structÆvar Arnfjörð Bjarmason, Nov 17, 2022
  32. 2/4 ls-tree: use a "struct options"Ævar Arnfjörð Bjarmason, Nov 17, 2022
  33. 4/4 ls-tree: make "line_termination" less genericÆvar Arnfjörð Bjarmason, Nov 17, 2022
  34. 0/4 ls-tree: pass state in struct, not globalsTeng Long, Nov 21, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.