git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Avoid using deprecated features in Git's GitHub workflows

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 7, 2022, 22:42 UTC
Message-ID
<221207.86r0xa9618.gmgdl@evledraar.gmail.com>
In-Reply-To
<pull.1440.git.1670423680.gitgitgadget@gmail.com>
On Wed, Dec 07 2022, Johannes Schindelin via GitGitGadget wrote:
Show 6 quoted lines
> I waited for quite a while with submitting this because I did not want to
> interfere with patch series that are in flight, but it seems that this was
> unwise, as there is now a patch floating about (ab/ci-retire-set-output)
> that partially fulfills this here patch series' purpose. However, these
> patches are more complete, so I proposed to supersede that patch with this
> more comprehensive solution.

What does "more complete" here mean? Just that this series is doing more things than stand-alone patches?

> This patch series is based on od/ci-use-checkout-v3-when-applicable.
>
> Johannes Schindelin (4):
>   ci: use a newer `github-script` version

Is this the patch that needs or interacts with od/ci-use-checkout-v3-when-applicable?

I don't see it in "What's Cooking", but "seen" currently has "gitster/js/ci-set-output", which looks to be from [1]

>   ci: avoid deprecated `set-output` workflow command
This is byte-for-byte the same as the second hunk in my [2].
>   ci: avoid using deprecated {up,down}load-artifacts Action

Most of this looks good & doesn't duplicate any existing patch, but why is there a change in there that disables the uploading of failed test directories for the "linux32" job?

>   ci(l10n): avoid using the deprecated `set-output` workflow command

This does the same as the first hunk in my [2], you're just using two "echo", I used a here-doc.

I think what would make it valuable to bundle these up is if doing so would resolve some tricky interference between these patches.

But I don't see that that's the case, and we can e.g. start writing to "$GITHUB_OUTPUT" independent of other changes.

1. https://lore.kernel.org/git/pull.1387.git.1667902408921.gitgitgadget@gmail.com/
2. https://lore.kernel.org/git/patch-v2-1.1-4e7db0db3be-20221207T014848Z-avarab@gmail.com/
Previous: Junio C Hamano
Message 11 of 11 in “Avoid using deprecated features in Git's GitHub workflows”
  1. 0/4 Avoid using deprecated features in Git's GitHub workflowsJohannes Schindelin via GitGitGadget, Dec 7, 2022
  2. 1/4 ci: use a newer `github-script` versionJohannes Schindelin via GitGitGadget, Dec 7, 2022
  3. Taylor BlauDec 7, 2022
  4. 2/4 ci: avoid deprecated `set-output` workflow commandJohannes Schindelin via GitGitGadget, Dec 7, 2022
  5. Taylor BlauDec 7, 2022
  6. 3/4 ci: avoid using deprecated {up,down}load-artifacts ActionJohannes Schindelin via GitGitGadget, Dec 7, 2022
  7. 4/4 ci(l10n): avoid using the deprecated `set-output` workflow commandJohannes Schindelin via GitGitGadget, Dec 7, 2022
  8. Taylor BlauDec 7, 2022
  9. Junio C HamanoDec 7, 2022
  10. Junio C HamanoDec 8, 2022
  11. Ævar Arnfjörð BjarmasonDec 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.