Re: [PATCH v2 2/4] submodule: move status parsing into function

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 12, 2022, 08:27 UTC
Message-ID: <221012.86zge1moki.gmgdl@evledraar.gmail.com>
In-Reply-To: <20221011232604.839941-3-calvinwan@google.com>

On Tue, Oct 11 2022, Calvin Wan wrote:

Just commenting on one case, but this is in other parts of the series (e.g. your additions in submodule.c):

Show 5 quoted lines

> +			BUG("invalid status --porcelain=2 line %s",
> +				buf);
> [...]
> -				BUG("invalid status --porcelain=2 line %s",
> -				    buf.buf);

Your editor's indentation settings need fixing. Arguments should align with the opening "(", here you replaced 4 spaces with a "\t".

A "\t" is == 8 spaces for the purposes of our identation, if you need 7 spaces to align with the "7" you insert 7 spaces, if it's 8 a "\t", then for one more a "\t" and one space etc.