Re: [PATCH v3 4/6] log: refactor "rev.pending" code in cmd_show()
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Aug 5, 2022, 09:01 UTC
- Message-ID
- <220805.868ro3rrkf.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <xmqqy1w46luv.fsf@gitster.g>
On Thu, Aug 04 2022, Junio C Hamano wrote:
Show 10 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > [...] >> ... or in any case we'd want to re-rest that the compilers we >> care about similarly optimize it. > > Perhaps. Using struct assignment only when we feel an urge to use > memcpy() in a new code (or in the postimage of a newly rewritten > code), instead of doing a bulk update, would give us a chance to > start small and vet the result with compilers of such a small scale > rewrite carefully to build confidence, hopefully?
I think it would make sense to set out a baloon for it, but as some of it (and I'll note this in a re-roll) involves some new C99 support I'd prefer not to conflate that with this series.