Re: [PATCH] repack: document there is no need to avoid delta-base-offset

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 19, 2022, 21:54 UTC
Message-ID: <220719.86h73cvkbw.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqqbktk93kl.fsf_-_@gitster.g>

On Tue, Jul 19 2022, Junio C Hamano wrote:

Show 10 quoted lines

> As continued use of 1.4.4 by people stopped being an issue long time
> ago, we can safely remove the warning about interoperability that we
> added in 1.6.0 when the use of delta-base-offset has become default.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
>  * Instead of outright removing, it probably is a good idea to hint
>    the reason why the now seemingly useless configuration variable
>    is there, perhaps.

We cover that in git-config(1), I don't see a reason to continue dicsussing it in git-repack(1) as well. Just above the paragraph you're modifying we link to it.

The patch you've got here also replaces a specific reason (pre-1.4.4) with a vague reference to "hardly any reason", leaving the reader wondering what that reason is...