Re: [RFC PATCH 1B] credential-cache--daemon: close input before exit-ing

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 7, 2022, 13:00 UTC
Message-ID: <220707.86pmih847l.gmgdl@evledraar.gmail.com>
In-Reply-To: <c344938b-afe9-edef-1e0d-fbe2425c8c01@ramsayjones.plus.com>

On Thu, Jul 07 2022, Ramsay Jones wrote:

Show 17 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  builtin/credential-cache--daemon.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/builtin/credential-cache--daemon.c b/builtin/credential-cache--daemon.c
> index 4c6c89ab0d..556393498f 100644
> --- a/builtin/credential-cache--daemon.c
> +++ b/builtin/credential-cache--daemon.c
> @@ -138,6 +138,7 @@ static void serve_one_client(FILE *in, FILE *out)
>  		 * process actually ends, which closes the socket and gives
>  		 * them EOF.
>  		 */
> +		fclose(in);
>  		exit(0);
>  	}
>  	else if (!strcmp(action.buf, "erase"))

This is called by a function that will also close stdout, shouldn't we be closing it here?