git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] [RFC] git-p4: improve encoding handling to support inconsistent encodings

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 13, 2022, 13:59 UTC
Message-ID
<220413.86zgkpf5g7.gmgdl@evledraar.gmail.com>
In-Reply-To
<pull.1206.v2.git.1649831069578.gitgitgadget@gmail.com>
On Wed, Apr 13 2022, Tao Klerks via GitGitGadget wrote:
> Under python2, git-p4 "naively" writes the Perforce bytestream into git
> metadata (and does not set an "encoding" header on the commits); this
> means that any non-utf-8 byte sequences end up creating invalidly-encoded
> commit metadata in git.

If it doesn't have an "encoding" header isn't any sequence of bytes OK with git, so how does it create invalid metadata in git?

Do you mean that something on the Python side gets confused and doesn't correctly encode it in that case, or that it's e.g. valid UTF-8 but we're lacking the metadata?

Previous: Tao Klerks via GitGitGadgetNext: Tao Klerks
Message 3 of 13 in “[RFC] git-p4: improve encoding handling to support inconsistent encodings”
  1. [RFC] git-p4: improve encoding handling to support inconsistent encodingsTao Klerks via GitGitGadget, Apr 11, 2022
  2. [RFC] git-p4: improve encoding handling to support inconsistent encodingsTao Klerks via GitGitGadget, Apr 13, 2022
  3. Ævar Arnfjörð BjarmasonApr 13, 2022
  4. Tao KlerksApr 13, 2022
  5. Ævar Arnfjörð BjarmasonApr 13, 2022
  6. Tao KlerksApr 14, 2022
  7. Andrew OakleyApr 13, 2022
  8. Tao KlerksApr 14, 2022
  9. Andrew OakleyApr 17, 2022
  10. Tao KlerksApr 19, 2022
  11. git-p4: improve encoding handling to support inconsistent encodingsTao Klerks via GitGitGadget, Apr 19, 2022
  12. Tao KlerksApr 19, 2022
  13. git-p4: improve encoding handling to support inconsistent encodingsTao Klerks via GitGitGadget, Apr 30, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.