git/list[1] front-page[2] threads[3] people[4] search[5] about
 

ab/plug-leak-in-revisions (was: What's cooking in git.git (Apr 2022, #03; Tue, 12))

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 13, 2022, 20:08 UTC
Message-ID
<220413.86bkx4eobr.gmgdl@evledraar.gmail.com>
In-Reply-To
<xmqq8rsab5do.fsf@gitster.g>
On Tue, Apr 12 2022, Junio C Hamano wrote:
Show 35 quoted lines
> * ab/plug-leak-in-revisions (2022-04-03) 28 commits
>  - revisions API: add a TODO for diff_free(&revs->diffopt)
>  - revisions API: have release_revisions() release "topo_walk_info"
>  - revisions API: have release_revisions() release "date_mode"
>  - revisions API: call diff_free(&revs->pruning) in revisions_release()
>  - revisions API: release "reflog_info" in release revisions()
>  - revisions API: clear "boundary_commits" in release_revisions()
>  - revisions API: have release_revisions() release "prune_data"
>  - revisions API: have release_revisions() release "grep_filter"
>  - revisions API: have release_revisions() release "filter"
>  - revisions API: have release_revisions() release "cmdline"
>  - revisions API: have release_revisions() release "mailmap"
>  - revisions API: have release_revisions() release "commits"
>  - revisions API users: use release_revisions() for "prune_data" users
>  - revisions API users: use release_revisions() with UNLEAK()
>  - revisions API users: use release_revisions() in builtin/log.c
>  - revisions API users: use release_revisions() in http-push.c
>  - revisions API users: add "goto cleanup" for release_revisions()
>  - stash: always have the owner of "stash_info" free it
>  - revisions API users: use release_revisions() needing REV_INFO_INIT
>  - revision.[ch]: document and move code declared around "init"
>  - revisions API users: add straightforward release_revisions()
>  - revision.[ch]: provide and start using a release_revisions()
>  - cocci: add and apply free_commit_list() rules
>  - format-patch: don't leak "extra_headers" or "ref_message_ids"
>  - string_list API users: use string_list_init_{no,}dup
>  - blame: use "goto cleanup" for cleanup_scoreboard()
>  - t/helper/test-fast-rebase.c: don't leak "struct strbuf"
>  - Merge branch 'ds/partial-bundle-more' into ab/plug-leak-in-revisions
>
>  Plug the memory leaks from the trickiest API of all, the revision
>  walker.
>
>  Will merge to 'next'?
>  source: <cover-v5-00.27-00000000000-20220402T102002Z-avarab@gmail.com>

I think it should be ready with my just-submitted re-roll, which fixes a trivial nit spotted by Phillip Wood by removing a useless NULL check: https://lore.kernel.org/git/cover-v6-00.27-00000000000-20220413T195935Z-avarab@gmail.com/

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 10 in “What's cooking in git.git (Apr 2022, #03; Tue, 12)”
  1. Junio C HamanoApr 12, 2022
  2. Philippe BlainApr 12, 2022
  3. CVE-2022-24765 and core.sharedRepository (was: What's cooking in git.git (Apr 2022, #03; Tue, 12))Ævar Arnfjörð Bjarmason, Apr 12, 2022
  4. demerphqApr 13, 2022
  5. Junio C HamanoApr 13, 2022
  6. ab/plug-leak-in-revisions (was: What's cooking in git.git (Apr 2022, #03; Tue, 12))Ævar Arnfjörð Bjarmason, Apr 13, 2022
  7. Junio C HamanoApr 13, 2022
  8. Ævar Arnfjörð BjarmasonApr 14, 2022
  9. Junio C HamanoApr 14, 2022
  10. ab/ci-setup-simplify etc. (was: What's cooking in git.git (Apr 2022, #03; Tue, 12))Ævar Arnfjörð Bjarmason, Apr 13, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.