git/list[1] front-page[2] threads[3] people[4] search[5] about
 

jh/p4-various-fixups (was: What's cooking in git.git (Mar 2022, #07; Wed, 30))

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 31, 2022, 09:41 UTC
Message-ID
<220331.86czi2sbg4.gmgdl@evledraar.gmail.com>
In-Reply-To
<xmqqee2i50h9.fsf@gitster.g>
On Wed, Mar 30 2022, Junio C Hamano wrote:
Show 31 quoted lines
> Also, there are a couple of "git p4" patches, for which we seem to
> totally lack reviewers.  Help is appreciated, here, too.
> [...]
> * jh/p4-various-fixups (2022-02-10) 22 commits
>  - git-p4: sort imports
>  - git-p4: seperate multiple statements onto seperate lines
>  - git-p4: move inline comments to line above
>  - git-p4: only seperate code blocks by a single empty line
>  - git-p4: compare to singletons with "is" and "is not"
>  - git-p4: normalize indentation of lines in conditionals
>  - git-p4: ensure there is a single space around all operators
>  - git-p4: ensure every comment has a single #
>  - git-p4: remove spaces between dictionary keys and colons
>  - git-p4: remove redundant backslash-continuations inside brackets
>  - git-p4: remove extraneous spaces before function arguments
>  - git-p4: place a single space after every comma
>  - git-p4: removed brackets when assigning multiple return values
>  - git-p4: remove spaces around default arguments
>  - git-p4: remove padding from lists, tuples and function arguments
>  - git-p4: sort and de-duplcate pylint disable list
>  - git-p4: remove commented code
>  - git-p4: convert descriptive class and function comments into docstrings
>  - git-p4: improve consistency of docstring formatting
>  - git-p4: indent with 4-spaces
>  - git-p4: remove unneeded semicolons from statements
>  - git-p4: add blank lines between functions and class definitions
>
>  Various cleanups to "git p4".
>
>  Needs review.
>  source: <20220210164627.279520-1-jholdsworth@nvidia.com>

The tip here lacks a Signed-Off-By, but this otherwise looks good to me.

I don't have a setup to actually test it, but aside from the import re-shuffling these are all purely stylistic changes.

Previous: Junio C HamanoNext: Joel Holdsworth
Message 2 of 9 in “What's cooking in git.git (Mar 2022, #07; Wed, 30)”
  1. Junio C HamanoMar 31, 2022
  2. jh/p4-various-fixups (was: What's cooking in git.git (Mar 2022, #07; Wed, 30))Ævar Arnfjörð Bjarmason, Mar 31, 2022
  3. Joel HoldsworthApr 1, 2022
  4. ab/commit-plug-leaks (was: What's cooking in git.git (Mar 2022, #07; Wed, 30))Ævar Arnfjörð Bjarmason, Mar 31, 2022
  5. tk/ambiguous-fetch-refspec (was: What's cooking in git.git (Mar 2022, #07; Wed, 30))Ævar Arnfjörð Bjarmason, Mar 31, 2022
  6. ab/ci-setup-simplify + ab/ci-github-workflow-markup (was: What's cooking in git.git (Mar 2022, #07; Wed, 30))Ævar Arnfjörð Bjarmason, Mar 31, 2022
  7. rc/fetch-refetch (was: What's cooking in git.git (Mar 2022, #07; Wed, 30))Robert Coup, Mar 31, 2022
  8. Glen ChooMar 31, 2022
  9. Philippe BlainApr 3, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.