Re: [PATCH v2] switch: mention the --detach option when dying due to lack of a branch
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Feb 25, 2022, 11:57 UTC
- Message-ID
- <220225.86h78n88gb.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <xmqqv8x4m6jn.fsf@gitster.g>
On Thu, Feb 24 2022, Junio C Hamano wrote:
Show 22 quoted lines
> Alex Henrie <alexhenrie24@gmail.com> writes:
>> diff --git a/t/t2060-switch.sh b/t/t2060-switch.sh
>> index ebb961be29..f54691bac9 100755
>> --- a/t/t2060-switch.sh
>> +++ b/t/t2060-switch.sh
>> @@ -32,6 +32,17 @@ test_expect_success 'switch and detach' '
>> test_must_fail git symbolic-ref HEAD
>> '
>>
>> +test_expect_success 'suggestion to detach' '
>> + test_must_fail git switch main^{commit} 2>stderr &&
>> + test_i18ngrep "try again with the --detach option" stderr
>> +'
>> +
>> +test_expect_success 'suggestion to detach is suppressed with advice.suggestDetachingHead=false' '
>> + test_config advice.suggestDetachingHead false &&
>> + test_must_fail git switch main^{commit} 2>stderr &&
>> + test_i18ngrep ! "try again with the --detach option" stderr
>> +'
>
> OK, we try to be consistent with other tests in the file, and leave
> s/test_i18n// to a file-wide clean-up outside the topic.FWIW that's not the case here. This is the first use of test_i18ngrep in this file.
But better to use test_cmp as noted in <220224.86sfs8abj6.gmgdl@evledraar.gmail.com> in the sid-thread.