Re: 1.7.3.4 build regression

From: Jeremy Huddleston <jeremyhu@apple.com>
Date: Dec 17, 2010, 04:02 UTC
Message-ID: <21774743-8BA8-4A1C-BDCF-1E3F7D85EFB5@apple.com>
In-Reply-To: <20101217034123.GA7362@burratino>

On Dec 16, 2010, at 19:41, Jonathan Nieder wrote:

Show 16 quoted lines

> Hi Jeremy,
> 
> Jeremy Huddleston wrote:
> 
>> 1.7.3.4 seems to have a regression (over 1.7.3.2 ... didn't try 1.7.3.3)
>> building.  I do:
>> 
>> make
>> (strip the built executables)
>> make install
>> 
>> During 'make install', the executables get remade even though they
>> shouldn't be.
> 
> Just a wild guess: do you pass CC on the "make" and not the "make
> install" command line?

Yes.  Good guess.  Why would that be affecting it?

Some updates:

It occurs with 1.7.3.3 as well.

"make" line is: /Developer/usr/bin/make -C /tmp/Git-16.roots/Git-16~obj/i386/ -j`sysctl -n hw.activecpu` prefix=/usr NO_FINK=YesPlease NO_DARWIN_PORTS=YesPlease RUNTIME_PREFIX=YesPlease GITGUI_VERSION=0.12.0 V=1 CFLAGS='-ggdb3 -Os -pipe -Wall -Wformat-security -D_FORTIFY_SOURCE=2' 'CC=cc -arch i386' 'uname_M=i386' 'uname_P=i386' && touch /tmp/Git-16.roots/Git-16~obj/i386/build.timestamp

"make install" line is:
/Developer/usr/bin/make -C /tmp/Git-16.roots/Git-16~obj/i386 -j`sysctl -n hw.activecpu` prefix=/usr NO_FINK=YesPlease NO_DARWIN_PORTS=YesPlease RUNTIME_PREFIX=YesPlease GITGUI_VERSION=0.12.0 V=1 CFLAGS='-ggdb3 -Os -pipe -Wall -Wformat-security -D_FORTIFY_SOURCE=2' \          'DESTDIR=/tmp/Git-16.roots/Git-16~dst' \
          install