git/list[1] front-page[2] threads[3] people[4] search[5] about
 

hn/reftable-coverity-fixes (was: What's cooking in git.git (Dec 2021, #06; Mon, 27))

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 28, 2021, 13:40 UTC
Message-ID
<211228.86lf04j0lg.gmgdl@evledraar.gmail.com>
In-Reply-To
<xmqq7dbpvb0q.fsf@gitster.g>
On Mon, Dec 27 2021, Junio C Hamano wrote:
Show 25 quoted lines
> * hn/reftable-coverity-fixes (2021-12-22) 18 commits
>  - reftable: be more paranoid about 0-length memcpy calls
>  - reftable: add print functions to the record types
>  - reftable: make reftable_record a tagged union
>  - reftable: remove outdated file reftable.c
>  - reftable: implement record equality generically
>  - reftable: make reftable-record.h function signatures const correct
>  - reftable: handle null refnames in reftable_ref_record_equal
>  - reftable: drop stray printf in readwrite_test
>  - reftable: order unittests by complexity
>  - reftable: all xxx_free() functions accept NULL arguments
>  - reftable: fix resource warning
>  - reftable: ignore remove() return value in stack_test.c
>  - reftable: check reftable_stack_auto_compact() return value
>  - reftable: fix resource leak blocksource.c
>  - reftable: fix resource leak in block.c error path
>  - reftable: fix OOB stack write in print functions
>  - Merge branch 'hn/create-reflog-simplify' into hn/reftable-coverity-fixes
>  - Merge branch 'hn/reftable' into hn/reftable-coverity-fixes
>
>  Problems identified by Coverity in the reftable code have been
>  corrected.
>
>  Will merge to 'next'?
>  source: <pull.1152.v5.git.git.1640199396.gitgitgadget@gmail.com>

It looks to me like the points you raised in https://lore.kernel.org/git/xmqqy24a4oyq.fsf@gitster.g/ are worth being addressed before a merge to 'next'. I.e. is that memcpy() paranoia needed / does it do anything?

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 3 of 10 in “What's cooking in git.git (Dec 2021, #06; Mon, 27)”
  1. Junio C HamanoDec 28, 2021
  2. ab/cat-file (was: What's cooking in git.git (Dec 2021, #06; Mon, 27))Ævar Arnfjörð Bjarmason, Dec 28, 2021
  3. hn/reftable-coverity-fixes (was: What's cooking in git.git (Dec 2021, #06; Mon, 27))Ævar Arnfjörð Bjarmason, Dec 28, 2021
  4. ab/ambiguous-object-name (was: What's cooking in git.git (Dec 2021, #06; Mon, 27))Ævar Arnfjörð Bjarmason, Dec 28, 2021
  5. ab/only-single-progress-at-once (was: What's cooking in git.git (Dec 2021, #06; Mon, 27))Ævar Arnfjörð Bjarmason, Dec 28, 2021
  6. Elijah NewrenDec 28, 2021
  7. Junio C HamanoDec 30, 2021
  8. Glen ChooJan 4, 2022
  9. Junio C HamanoJan 10, 2022
  10. tl/ls-tree-oid-only (was: What's cooking in git.git (Dec 2021, #06; Mon, 27))Teng Long, Jan 1, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.