Re: [PATCH] fetch-pack: add TRANSLATORS notice for packfile ready messages

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 15, 2021, 15:21 UTC
Message-ID: <211115.86ilwtsasb.gmgdl@evledraar.gmail.com>
In-Reply-To: <2a4428a5-91d9-a0a5-39cd-eefa1c92024e@gmail.com>

On Mon, Nov 15 2021, Bagas Sanjaya wrote:

Show 15 quoted lines

> On 14/11/21 16.50, Ævar Arnfjörð Bjarmason wrote:
>> If something isn't meant to be translated do this instead:
>>      die(_("expected no other sections to be sent after no '%s"),
>> "ready");
>> I.e. pass it as a parameter.
>> There can then be a "TRANSLATORS" comment that explains that it's
>> the
>> string "ready", in reference to that protocol keyword. We do it that way
>> in various other places, and it completely avoids the potential problem
>> of a should not be translated string being translated.
>> 
>
> Something like:
> /* TRANSLATORS: The 'ready' string is the protocol keyword. Leave it
>    as is. */ ?

No, e.g. "TRANSLATORS: The parameter will be 'ready', a protocol keyword" or something.

I.e. you don't need to instruct them to leave it as-is if there's no way they can't leave it as-is, since it's being passed as a parameter.

> But I have admitted that I lean to your suggestion.

Yes you could also embed it in the string, but why do that in this case? Seems like zero benefit, and potential translator confusion.