Re: ms/customizable-ident-expansion

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 8, 2021, 19:14 UTC
Message-ID: <211108.864k8mfocg.gmgdl@evledraar.gmail.com>
In-Reply-To: <CABFYoQA82u8Um6L439_bU4a+WpkdXOcbU8foPjqnVw+4MnNU0A@mail.gmail.com>

On Sun, Nov 07 2021, Maksym Sobolyev wrote:

Show 7 quoted lines

> Junio, well it works and passes Occam Razor test. I even added a
> reasonable number of test cases. As I tried to explain at least once,
> having it per-directory might be advantageous, if the project pulls
> sources from all different places where you might "mute" ID
> replacement for certain parts of the tree or use a different one. Most
> of that would have to be thrown away if the feature is to be reworked
> to your liking.

Yes, isn't there also a practical use for this in the source trees of the various *BSDs who import each other's sources (but I don't know if it's useful for that).

Show 9 quoted lines

> Totay I logged into one of our products and got this message:
>
> + sudo chroot /voicelog/src su -l sobomax
> This fortune brought to you by:
> $FreeBSD: 3325fdce090fbf738dcb1f8535d16217789cbe4e $
>
> I did not know such a fortune ever existed, it has probably been
> developed around a long-long time ago before git or even linux
> existed. Just as many other more useful features around the same idea.

This on the other hand looks both neat and a bit scary, so something that previously left "$FreeBSD$" alone started expanding it? Hrm, I guess since you need to set "ident" it's no big deal.

But I wonder if we'll see any downstream breakage for people who opt-in to this, who have code they didn't know about that expects an RCS/CVS version, and suddenly gets a SHA-1-sized hex string instead :)