Re: What's cooking in git.git (Jun 2015, #06; Wed, 24)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 25, 2015, 18:14 UTC
Message-ID: <20853ca02f86d3e524fa961eef1f1d2e@www.dscho.org>
In-Reply-To: <xmqqtwtw0w20.fsf@gitster.dls.corp.google.com>

Hi Junio,

On 2015-06-25 15:14, Junio C Hamano wrote:

Show 12 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>> - I *think* that the current `recreate_opt()` is fine, but if it
>> is used more, we will have to quote the arguments to guard against
>> spaces and quotes and whatnot
> 
> I admit that that was the reaction I had when I saw it for the first
> time, until I realized how it is used.  And this one I have to
> disagree.  recreate-opt is used to munge a single argument, suitable
> to be placed into argv[] for execv() like thing---there is no need
> for shell quoting there.  It is a job for the caller that gets its
> result to shell quote if it wants to pass the result to a shell.

Ah yes, no single command-line is constructed from those reconstructed options. So yes, you're right, all is good!

Ciao, Dscho