Re: [PATCH 1/1] checkout: add simple check for 'git checkout -b'
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Aug 29, 2019, 20:07 UTC
- Message-ID
- <206819d0-8066-e8e8-8967-8a1db05eea26@gmail.com>
- In-Reply-To
- <7e406b35-9ff6-348f-bdee-7540381f000e@gmail.com>
On 8/29/2019 2:54 PM, Phillip Wood wrote:
Show 9 quoted lines
> Hi Stolee
>
> On 29/08/2019 18:01, Derrick Stolee via GitGitGadget wrote:
>> +
>> + if (argc == 3 && !strcmp(argv[1], "-b")) {
>> + /*
>> + * User ran 'git checkout -b <branch>' and expects
>
> What if the user ran 'git checkout -b<branch>'? Then argc == 2.Good catch. I'm tempted to say "don't do that" to keep this simple. They won't have incorrect results, just slower than the "with space" option.
However, if there is enough interest in correcting the "-b<branch>" case, then I can make another attempt at this.
-Stolee