[PATCH v2 1/4] http.c: remove unnecessary casts to long
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Mar 19, 2025, 22:23 UTC
- Message-ID
- <204e5e18d28951c3cb3c2e70f41873b263b65746.1742423021.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1742423021.git.me@ttaylorr.com>
When parsing 'http.lowSpeedLimit' and 'http.lowSpeedTime', we explicitly cast the result of 'git_config_int()' to a long before assignment. This cast has been in place since all the way back in 58e60dd203 (Add support for pushing to a remote repository using HTTP/DAV, 2005-11-02).
But that cast has always been unnecessary, since long is guaranteed to be at least as wide as int. Let's drop the cast accordingly.
Noticed-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Taylor Blau <me@ttaylorr.com> --- http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/http.c b/http.c index 0c9a872809..0cbcb079b2 100644 --- a/http.c +++ b/http.c @@ -438,11 +438,11 @@ static int http_options(const char *var, const char *value, return 0; } if (!strcmp("http.lowspeedlimit", var)) { - curl_low_speed_limit = (long)git_config_int(var, value, ctx->kvi); + curl_low_speed_limit = git_config_int(var, value, ctx->kvi); return 0; } if (!strcmp("http.lowspeedtime", var)) { - curl_low_speed_time = (long)git_config_int(var, value, ctx->kvi); + curl_low_speed_time = git_config_int(var, value, ctx->kvi); return 0; }
-- 2.49.0.4.ge59cf92f8d