Re: [PATCH v3 3/3] ls-files: use and update the untracked cache
- From
- Aniket Gupta <aniketgupta3001@gmail.com>
- Date
- Nov 20, 2026, 17:24 UTC
- Message-ID
- <20261120172420.47728-1-aniketgupta3001@gmail.com>
- In-Reply-To
- <20261023-ls-files-untracked-cache-v3-3-292260e95f53@gmail.com>
Hi Tamir,
Thanks for working on this.
> + * With index.skipHash, the checksum cannot detect concurrent index > + * changes. Lock the index before reading it.
With core.untrackedCache=true and a cold cache this holds index.lock for the whole scan, so a concurrent git add will fail. With 60k untracked files, a background "git ls-files -o --exclude-standard" and "git add new1" 30ms later give
fatal: Unable to create '.git/index.lock': File exists.
master doesnt do this and cmd_status() locks only after collecting. Does the lock need to be taken before reading? verify_index_from() seems to handle skipHash and locking after fill_directory() is working except for the t7519 skiphash test.