git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/6] packfile: skip closing packs marked as do-not-close

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 20, 2026, 12:02 UTC
Message-ID
<20261120-pks-packfile-global-statistics-v1-6-19beb83b145f@pks.im>
In-Reply-To
<20261120-pks-packfile-global-statistics-v1-0-19beb83b145f@pks.im>

When closing a packfile to maintain the maximum number of open packs we completely ignore the `do_not_close` bit. That bit is only set by git-fast-import(1), and as that command allocates its packs manually it wouldn't add those packs to the list of all packfiles, and consequently we won't ever try to close such a packfile via `close_one_pack()`. But that feels like coincidence rather than proper design, and the result is rather fragile.

Skip over packfiles marked as do-not-close to reduce the fragility. This should not result in a user-visible change in behaviour.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 packfile.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/packfile.c b/packfile.c
index 0d5647c74c8..86ef3a79d9c 100644
--- a/packfile.c
+++ b/packfile.c
@@ -414,7 +414,8 @@ static int close_one_pack(void)
 	int accept_windows_inuse = 1;
 
 	for (e = all_packfiles.head; e; e = e->next) {
-		if (e->pack->pack_fd == -1)
+		if (e->pack->pack_fd == -1 ||
+		    e->pack->do_not_close)
 			continue;
 		find_lru_pack(e->pack, &lru_p, &mru_w, &accept_windows_inuse);
 	}
-- 
2.56.1.831.g720f3f5937.dirty
Previous: Patrick Steinhardt
Message 7 of 7 in “packfile: some lifecycle improvements”
  1. 0/6 packfile: some lifecycle improvementsPatrick Steinhardt, Nov 20, 2026
  2. 1/6 builtin/fast-import: stop reporting packfile statisticsPatrick Steinhardt, Nov 20, 2026
  3. 2/6 packfile: rename lifecycle functionsPatrick Steinhardt, Nov 20, 2026
  4. 3/6 packfile: inline `open_packed_git_1()`Patrick Steinhardt, Nov 20, 2026
  5. 4/6 packfile: introduce function to free a packfilePatrick Steinhardt, Nov 20, 2026
  6. 5/6 packfile: maintain process-wide limits globallyPatrick Steinhardt, Nov 20, 2026
  7. 6/6 packfile: skip closing packs marked as do-not-closePatrick Steinhardt, Nov 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.