[PATCH 6/6] packfile: skip closing packs marked as do-not-close
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Nov 20, 2026, 12:02 UTC
- Message-ID
- <20261120-pks-packfile-global-statistics-v1-6-19beb83b145f@pks.im>
- In-Reply-To
- <20261120-pks-packfile-global-statistics-v1-0-19beb83b145f@pks.im>
When closing a packfile to maintain the maximum number of open packs we completely ignore the `do_not_close` bit. That bit is only set by git-fast-import(1), and as that command allocates its packs manually it wouldn't add those packs to the list of all packfiles, and consequently we won't ever try to close such a packfile via `close_one_pack()`. But that feels like coincidence rather than proper design, and the result is rather fragile.
Skip over packfiles marked as do-not-close to reduce the fragility. This should not result in a user-visible change in behaviour.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- packfile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/packfile.c b/packfile.c index 0d5647c74c8..86ef3a79d9c 100644 --- a/packfile.c +++ b/packfile.c @@ -414,7 +414,8 @@ static int close_one_pack(void) int accept_windows_inuse = 1; for (e = all_packfiles.head; e; e = e->next) { - if (e->pack->pack_fd == -1) + if (e->pack->pack_fd == -1 || + e->pack->do_not_close) continue; find_lru_pack(e->pack, &lru_p, &mru_w, &accept_windows_inuse); }
-- 2.56.1.831.g720f3f5937.dirty