git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 03/12] commit-graph: expose function to validate a commit graph chain

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 16, 2026, 13:07 UTC
Message-ID
<20261116-pks-odb-pluggable-commit-graphs-v1-3-a83fc1ff0808@pks.im>
In-Reply-To
<20261116-pks-odb-pluggable-commit-graphs-v1-0-a83fc1ff0808@pks.im>

When we have loaded a commit graph chain we need to validate whether all of its layers have been written with compatible settings. If that's not the case, then some functionality of the chain needs to be restricted as it would otherwise yield inconsistent results.

In a subsequent commit we'll move loading of commit graphs into the object database backend, and consequently the backend will have to perform this validation. Expose this functionality to prepare for this.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 commit-graph.c | 9 +++++++--
 commit-graph.h | 7 +++++++
 2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/commit-graph.c b/commit-graph.c
index c427a6f90f7..9464522feb5 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -574,6 +574,12 @@ static void validate_mixed_bloom_settings(struct commit_graph *g)
 	}
 }
 
+void commit_graph_validate_chain(struct commit_graph *g)
+{
+	validate_mixed_generation_chain(g);
+	validate_mixed_bloom_settings(g);
+}
+
 int commit_graph_link_base(struct commit_graph *g,
 			   struct commit_graph *base)
 {
@@ -695,8 +701,7 @@ struct commit_graph *load_commit_graph_chain_fd_st(struct object_database *odb,
 		}
 	}
 
-	validate_mixed_generation_chain(graph_chain);
-	validate_mixed_bloom_settings(graph_chain);
+	commit_graph_validate_chain(graph_chain);
 
 	fclose(fp);
 	strbuf_release(&line);
diff --git a/commit-graph.h b/commit-graph.h
index 8660c7fe698..dc4f6194c72 100644
--- a/commit-graph.h
+++ b/commit-graph.h
@@ -134,6 +134,13 @@ struct commit_graph *load_commit_graph_chain_fd_st(struct object_database *odb,
  */
 int commit_graph_link_base(struct commit_graph *g,
 			   struct commit_graph *base);
+
+/*
+ * Validate the chain of commit graph layers to ensure that all layers are
+ * compatible with one another. This may disable generation data and Bloom
+ * filters in case they aren't.
+ */
+void commit_graph_validate_chain(struct commit_graph *g);
 struct commit_graph *read_commit_graph_one(struct repository *repo,
 					   const char *dir);
 
-- 
2.56.1.763.g16177fe143.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 5 of 14 in “Introduce pluggable commit graphs”
  1. 00/12 Introduce pluggable commit graphsPatrick Steinhardt, Nov 16, 2026
  2. 01/12 commit-graph: simplify linking commit graph chainsPatrick Steinhardt, Nov 16, 2026
  3. Junio C HamanoNov 16, 2026
  4. 02/12 commit-graph: simplify reading a single commit graphPatrick Steinhardt, Nov 16, 2026
  5. 03/12 commit-graph: expose function to validate a commit graph chainPatrick Steinhardt, Nov 16, 2026
  6. 04/12 commit-graph: decide mergeable and chainable layers by depthPatrick Steinhardt, Nov 16, 2026
  7. 05/12 commit-graph: introduce common exit for `write_commit_graph_file()`Patrick Steinhardt, Nov 16, 2026
  8. 06/12 commit-graph: derive layer infos from the passed-in chainPatrick Steinhardt, Nov 16, 2026
  9. 07/12 commit-graph: split out check whether writing commit graphs is allowedPatrick Steinhardt, Nov 16, 2026
  10. 08/12 commit-graph: split out logic to write a new commit graph layerPatrick Steinhardt, Nov 16, 2026
  11. 09/12 commit-graph: mark incomplete commit graph chainsPatrick Steinhardt, Nov 16, 2026
  12. 10/12 odb/source: make commit graphs pluggablePatrick Steinhardt, Nov 16, 2026
  13. 11/12 odb/source-files: move logic to derive commit graph pathsPatrick Steinhardt, Nov 16, 2026
  14. 12/12 odb/source-files: internalize logic to derive commit graph pathsPatrick Steinhardt, Nov 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.