Re: [PATCH v2] bundle-uri: do not die on unresolvable relative URIs
- From
- Aniket Gupta <aniketgupta3001@gmail.com>
- Date
- Nov 5, 2026, 15:29 UTC
- Message-ID
- <20261105152906.566363-1-aniketgupta3001@gmail.com>
- In-Reply-To
- <auyH8BGzIsipPAJG@pks.im>
Hi Patrick,
Thanks for the review.
> This sentence is weird as it adds context that doesn't make sense > standalone. [...] Saying something like "relative_url() is now a thin > wrapper around that new function that continues to die, so existing > callers continue to behave the same" would be way less surprising.
Makes sense, I used your wording.
> Would it have made sense to split this out into a separate commit?
Yes, I think so. It is three patches now: add relative_url_gently(), hide the credentials in its error message, and then use it in bundle-uri.
> Wouldn't it make sense in this case to grep for the exact URL > printed, as the intent is to verify that we print the correct one? At > that point, we can probably just compare the full message.
Agreed, the test compares the whole message now.
Aniket