git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] http: preserve wwwauth_headers across redirects

From
Jeff King <peff@peff.net>
Date
Nov 4, 2026, 06:27 UTC
Message-ID
<20261104062701.GB1763458@coredump.intra.peff.net>
In-Reply-To
<xmqqwlqvmxa5.fsf@gitster.g>
On Mon, Nov 02, 2026 at 12:51:14AM -0800, Junio C Hamano wrote:
Show 18 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Junio C Hamano <gitster@pobox.com> writes:
> >
> >> For those of you who are watching from the sidelines, this v2 lacks
> >> the threading history.
> >>
> >> The v1 is at https://lore.kernel.org/git/20260602161150.1527493-1-aplattner@nvidia.com/
> >
> > Any takers?  It should be quite easy to be more interested and be a
> > better reviewer in the http transfer codepaths than I am.
> 
> Second call.  Anybody?
> 
> Unless we see some volunteers to give it a review in a few weeks, I
> will discard the topic out of my tree, as 'seen' has been crowded
> with topics that have been collecting dust without getting many
> reviews.

I gave it a review. In short, I think the patch is OK as-is, though I had a few small suggestions for the code (and it might be worth describing the "why is this safe" part in the commit message).

I think one of the reasons it didn't get much review is that the wwwauth is not well understood by other folks who work on HTTP, and the original author of the feature wasn't cc'd (I did in my review, though he's not super active these days, so I also wouldn't hold my breath).

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 9 in “http: preserve wwwauth_headers across redirects”
  1. http: preserve wwwauth_headers across redirectsAaron Plattner, Aug 20, 2026
  2. Junio C HamanoAug 20, 2026
  3. Junio C HamanoAug 25, 2026
  4. Junio C HamanoNov 2, 2026
  5. Jeff KingNov 4, 2026
  6. Junio C HamanoNov 4, 2026
  7. Jeff KingNov 4, 2026
  8. Matthew John CheethamNov 4, 2026
  9. Michal SuchánekNov 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.