git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/8] test-lib: drop unused test_external_has_tap variable

From
Jeff King <peff@peff.net>
Date
Oct 27, 2026, 17:32 UTC
Message-ID
<20261027173245.GB136740@coredump.intra.peff.net>
In-Reply-To
<20261027173205.GA97799@coredump.intra.peff.net>

The test_external_has_tap variable was used by test_external to remember whether an external test produced TAP output. But we dropped test_external in 5beca49a0b (test-lib: simplify by removing test_external, 2022-07-28). Drop this leftover initialization.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/test-lib.sh | 2 --
 1 file changed, 2 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index a893963f86..3d001b91da 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -771,8 +771,6 @@ test_success=0
 
 test_missing_prereq=
 
-test_external_has_tap=0
-
 die () {
 	code=$?
 	# This is responsible for running the atexit commands even when a
-- 
2.56.0.559.g7c1a1d8168
Previous: Jeff KingNext: Jeff King
Message 3 of 9 in “running unit tests inside a test-lib script”
  1. 0/8 running unit tests inside a test-lib scriptJeff King, Oct 27, 2026
  2. 1/8 unit-tests: report the correct unexpected argumentJeff King, Oct 27, 2026
  3. 2/8 test-lib: drop unused test_external_has_tap variableJeff King, Oct 27, 2026
  4. 3/8 test-lib: stop inventing a JUnit testcase for empty suitesJeff King, Oct 27, 2026
  5. 4/8 test-lib: allow an external program to supply TAP outputJeff King, Oct 27, 2026
  6. 5/8 t: run clar unit tests through test-lib.shJeff King, Oct 27, 2026
  7. 6/8 t: drop redundant unit-test invocationsJeff King, Oct 27, 2026
  8. 7/8 test-tool: drop the run-command testsuite modeJeff King, Oct 27, 2026
  9. 8/8 test-lib: drop the shell JUnit XML reporting codeJeff King, Oct 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.