git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v7 1/1] archive-zip: refactor 'path too long' error message to use Q_()

From
Kkerylefondji7@gmail.com <kerylefondji7@gmail.com>
Date
Oct 26, 2026, 19:04 UTC
Message-ID
<20261026190423.1925-2-kerylefondji7@gmail.com>
In-Reply-To
<20261026190423.1925-1-kerylefondji7@gmail.com>
From: Keryle Fondji <kerylefondji7@gmail.com>

Replace _() with Q_() in the 'path too long' error message. Although pathlen is always greater than 0xffff when this error is hit, Q_() is required to support correct translation for languages that require different plural forms depending on the count.

Signed-off-by: Keryle Fondji <kerylefondji7@gmail.com>
---
 archive-zip.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/archive-zip.c b/archive-zip.c
index 6f73ca6d58..160efd878f 100644
--- a/archive-zip.c
+++ b/archive-zip.c
@@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,
 	}
 
 	if (pathlen > 0xffff) {
-		return error(_("path too long (%d chars, SHA1: %s): %s"),
-				(int)pathlen, oid_to_hex(oid), path);
+		return error(Q_("path too long (%d char, SHA1: %s): %s",
+				"path too long (%d chars, SHA1: %s): %s",
+				pathlen),
+			     (int)pathlen, oid_to_hex(oid), path);
 	}
 
 	if (S_ISDIR(mode) || S_ISGITLINK(mode)) {
-- 
2.53.0
Previous: kerylefondji7@gmail.comNext: Junio C Hamano
Message 2 of 7 in “archive-zip: refactor 'path too long' error message”
  1. 0/1 archive-zip: refactor 'path too long' error messagekerylefondji7@gmail.com, Oct 26, 2026
  2. 1/1 archive-zip: refactor 'path too long' error message to use Q_()kerylefondji7@gmail.com, Oct 26, 2026
  3. Junio C HamanoOct 26, 2026
  4. 0/1 archive-zip: refactor 'path too long' error messagekerylefondji7@gmail.com, Oct 26, 2026
  5. 1/1 archive-zip: refactor 'path too long' error message to use Q_()kerylefondji7@gmail.com, Oct 26, 2026
  6. kerylefondji7@gmail.comOct 27, 2026
  7. Junio C HamanoOct 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.