Re: hostname: includeIf condition — anyone already working on this?

From: Jeff King <peff@peff.net>
Date: Sep 29, 2026, 18:28 UTC
Message-ID: <20260929182850.GB1710046@coredump.intra.peff.net>
In-Reply-To: <DLRSIZ3JV2DF.10GG1YB2D8DHW@iencinas.com>

On Tue, Sep 29, 2026 at 01:14:34PM +0100, Ignacio Encinas wrote:

Show 19 quoted lines

> > Yes, that is the tricky part. :) There were some patches in 2024:
> >
> >   https://lore.kernel.org/git/20240307205006.467443-1-ignacio@iencinas.com/
> >
> > where the issue came up. Based on my recollection and a quick skim of
> > the thread, I think the consensus was that it's OK to document that it
> > is system-dependent whether we'll match against a short of fully
> > qualified hostname. But exposing our view of the hostname via git-var
> > (e.g., "git var GIT_HOSTNAME") might be a helpful debugging aid.
> >
> > It looks like after review on v3 of the series we never saw more. I'd
> > guess the author (cc'd) just never got around to pushing it forward.
> 
> That's what happened. Similar to Isabella, I was looking for a small
> contribution but it ended up being more complicated than expected. I got
> a bit overwhelmed and decided to drop it.
> 
> I kept wondering if I should have communicated that, so apologies if
> that was the case.

Nah, it's not a big deal. This is open source, so everybody is here voluntarily, and it's normal for people to come in and out as time and interest permits. Plus the very reason that people end up dropping a series (getting overwhelmed) often makes it hard to decide whether and when to write the "I'm dropping this" email. :)

> I hope the discussion from 2024 is at least helpful now if this ends up
> being implemented by Isabella.

Yeah, I think there's a lot of good discussion there, and the patches themselves can probably give a boost to another attempt. Even if we did not finish it back then, thank you for the work so far.

-Peff