[PATCH v2 1/7] path: drop useless `safe_create_leading_directories_1()`
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 28, 2026, 09:51 UTC
- Message-ID
- <20260928-pks-create-repository-stateless-v2-1-a03612f703fa@pks.im>
- In-Reply-To
- <20260928-pks-create-repository-stateless-v2-0-a03612f703fa@pks.im>
The function `safe_create_leading_directories_1()` is being called by both `safe_create_leading_directories()` and its `_no_share()` variant. It is ultimately the exact same as the former of these functions though and is thus quite useless.
Drop the function and inline it into its callsites directly.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- path.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/path.c b/path.c index c3a709a928..69b06c9464 100644 --- a/path.c +++ b/path.c @@ -829,8 +829,8 @@ int safe_create_dir_in_gitdir(struct repository *repo, const char *path) return adjust_shared_perm(repo, path); } -static enum scld_error safe_create_leading_directories_1(struct repository *repo, - char *path) +enum scld_error safe_create_leading_directories(struct repository *repo, + char *path) { char *next_component = path + offset_1st_component(path); enum scld_error ret = SCLD_OK; @@ -884,15 +884,9 @@ static enum scld_error safe_create_leading_directories_1(struct repository *repo return ret; } -enum scld_error safe_create_leading_directories(struct repository *repo, - char *path) -{ - return safe_create_leading_directories_1(repo, path); -} - enum scld_error safe_create_leading_directories_no_share(char *path) { - return safe_create_leading_directories_1(NULL, path); + return safe_create_leading_directories(NULL, path); } enum scld_error safe_create_leading_directories_const(struct repository *repo,
-- 2.56.0.rc2.329.gd58861e689.dirty