[PATCH 0/2] some parse_revision_opt() bugfixes
- From
Jeff King <peff@peff.net>
- Date
- Sep 25, 2026, 20:33 UTC
- Message-ID
- <20260925203359.GA1506705@coredump.intra.peff.net>
- In-Reply-To
- <20260925082636.GA1493716@coredump.intra.peff.net>
On Fri, Sep 25, 2026 at 04:26:36AM -0400, Jeff King wrote:
Show 7 quoted lines
> > I have bisected this to cd439487 (revision: manage memory ownership of > > argv in setup_revisions(), 2025-09-19). > > Yep, definitely my fault. I don't have time to do a full write-up now, > but the most direct solution is: > [...] > But I think instead doing this:
I ended up reversing my decision there, for reasons that are explained in the second commit. But the good news is that doing so also revealed a related bug that predates even cd439487.
So here are the fixes. I apologize in advance for the length of the second commit message. At least I feel good about my decision to go to bed before writing it. ;)
[1/2]: revision: avoid reporting known options as unknown on error [2/2]: revision: handle argv movement in parse_revision_opt()
revision.c | 7 +++++-- t/t4201-shortlog.sh | 11 +++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-)
-Peff