Re: [PATCH v2] reflog: fix default expiry periods

From: Jeff King <peff@peff.net>
Date: Sep 24, 2026, 18:43 UTC
Message-ID: <20260924184331.GB747880@coredump.intra.peff.net>
In-Reply-To: <xmqqecei35n2.fsf@gitster.g>

On Thu, Sep 24, 2026 at 10:45:21AM -0700, Junio C Hamano wrote:

Show 20 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > On Thu, Sep 24, 2026 at 04:12:04PM +0200, Patrick Steinhardt wrote:
> >
> >> > >  #define REFLOG_EXPIRE_OPTIONS_INIT(now) { \
> >> > > -	.default_expire_total = now - 30 * 24 * 3600, \
> >> > > -	.default_expire_unreachable = now - 90 * 24 * 3600, \
> >> > > +	.default_expire_total = now - 90 * 24 * 3600, \
> >> > > +	.default_expire_unreachable = now - 30 * 24 * 3600, \
> >> > >  }
> >> > 
> >> > and the fix is very straight-forward.
> >> 
> >> Is this something that we want to fast-track for Git 2.56?
> >
> > The breakage was in v2.50.0, so it is not a new regression. OTOH it
> > seems quite obvious and low-risk. I'd be OK either way.
> 
> Yeah, I didn't know the breakage was that old.  Perhaps not many
> people are paying attention to reflog expiration?

Quite probably. The default expiration dates are somewhat arbitrary, and the reflogs themselves are somewhat ephemeral. Probably people would notice most on stashes, but those are also somewhat ephemeral.

-Peff