git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Bug] Porcelain allows creation of '@' branch

From
Jeff King <peff@peff.net>
Date
Sep 2, 2026, 07:37 UTC
Message-ID
<20260902073753.GC70165@coredump.intra.peff.net>
In-Reply-To
<CALnO6CCph_xC394v_BetLPyoriYc9dLZY42LsXhjVNdvt2e-cQ@mail.gmail.com>
On Mon, Aug 31, 2026 at 03:59:56PM -0400, D. Ben Knoble wrote:
Show 11 quoted lines
> But (with git refs list) we should see this creates a ref "refs/heads/@".
> 
> I happen to think that's extremely confusing given that "@" is the
> shorthand for HEAD, but… it's not against the current documented
> rules, I think. (e.g., "git switch @" will fail, since it sees "git
> switch HEAD"; using "refs/heads/@" will also fail.) git-checkout
> doesn't fail but also doesn't change to the "@" branch. Futzing with
> .git/HEAD and restoring the working tree works, but… yikes.
> 
> Of course, --branch mode is allowed to be stricter; maybe we should
> reject this case?

Yeah, sadly bare "@" is allowed in a component (but not "@{") because we've maintained strict backwards compatibility. So I don't think it's a _bug_ exactly, but in the past we have restricted the porcelain interfaces (so git-branch, but not git-update-ref) to avoid such footguns. The most notable one is HEAD:

  $ git check-ref-format refs/heads/HEAD; echo $?
  0
  $ git check-ref-format --branch HEAD; echo $?
  fatal: 'HEAD' is not a valid branch name
  128

which also shows off that "--branch" is a convenience option for using those stricter porcelain rules.

I think it would make sense to treat bare "@" the same as HEAD here. We probably _don't_ want to forbid any "@", though. Branches and tags like foo@bar are legal (if IMHO somewhat gross), and less likely to be used accidentally.

So I think there is no bug, in the sense that the system is working as designed, but it sure would be a nice feature to block this footgun.

> (I don't recall offhand where we describe valid branch names, if at all.)

I don't think we document the magic porcelain-tightening rules anywhere. That's probably OK in practice; the point of "check-ref-format --branch" is to check against them programatically.

-Peff
Previous: D. Ben KnobleNext: Kristoffer Haugsbakk
Message 3 of 16 in “[Bug] Porcelain allows creation of '@' branch”
  1. Bence CsókásAug 31, 2026
  2. D. Ben KnobleAug 31, 2026
  3. Jeff KingSep 2, 2026
  4. Kristoffer HaugsbakkSep 3, 2026
  5. Bence CsókásSep 3, 2026
  6. Ben KnobleSep 3, 2026
  7. Junio C HamanoSep 3, 2026
  8. Kristoffer HaugsbakkSep 6, 2026
  9. Bence CsókásOct 15, 2026
  10. Junio C HamanoOct 16, 2026
  11. D. Ben KnobleOct 16, 2026
  12. Kristoffer HaugsbakkOct 16, 2026
  13. Junio C HamanoOct 16, 2026
  14. Kristoffer HaugsbakkOct 17, 2026
  15. Junio C HamanoOct 17, 2026
  16. Junio C HamanoOct 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.