[PATCH v2 09/13] odb/packed: fix memory leaks when freeing source
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 2, 2026, 13:34 UTC
- Message-ID
- <20260902-pks-odb-registering-in-memory-sources-v2-9-c6ca12fdea4d@pks.im>
- In-Reply-To
- <20260902-pks-odb-registering-in-memory-sources-v2-0-c6ca12fdea4d@pks.im>
When freeing a "packed" source we don't close either its packs nor its multi-pack indices. This can cause memory leaks in case we create an ad-hoc packed source. As we used to always link packed sources to the main object database we never noticed this issue until now, but it's going to surface in subsequent commits where we stop linking them.
Plug the memory leaks by closing the source first.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- odb/source-packed.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/odb/source-packed.c b/odb/source-packed.c index 1d90e714e6..166e76e2d6 100644 --- a/odb/source-packed.c +++ b/odb/source-packed.c @@ -844,6 +844,7 @@ static void odb_source_packed_free(struct odb_source *source) chdir_notify_unregister(odb_source_packed_reparent, packed); + odb_source_close(source); for (struct packfile_list_entry *e = packed->packs.head; e; e = e->next) free(e->pack); packfile_list_clear(&packed->packs);
-- 2.55.0.979.g7e5102b832.dirty