Re: [PATCH v4 0/3] Reuse --contains traversal results

From: Jeff King <peff@peff.net>
Date: Jul 16, 2026, 09:19 UTC
Message-ID: <20260716091924.GB1212956@coredump.intra.peff.net>
In-Reply-To: <xmqqqzlpulkp.fsf@gitster.g>

On Mon, Jun 29, 2026 at 01:40:38PM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Tamir Duberstein <tamird@gmail.com> writes:
> 
> > git tag uses a memoized traversal for --contains, while git branch
> > and git for-each-ref repeat a reachability walk for each ref. Reuse
> > the memoized traversal when generation numbers can bound the walk.
> >
> > The first patch makes the memoized traversal reject cyclic replacement
> > histories. The last makes the non-memoized path report reachability
> > errors.
> 
> This unfortunately hasn't heard any responses since June 12th.  Are
> there remaining issues with it?  Or do people fundamentally have
> objections against this change?  Or things are too busy in general
> that there are more patches than there are folks willing to review
> them?

The last one. ;)

I think the direction is good and the patches themselves look fine. The only nit I had was that there's an unrelated (but good) comment cleanup in patch 1. That could be split into its own patch, but I am also fine to declare victory on v4.

-Peff