git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] strbuf: avoid redundant reset in strbuf_getwholeline()

From
Jeff King <peff@peff.net>
Date
Jul 14, 2026, 21:49 UTC
Message-ID
<20260714214941.GB4095533@coredump.intra.peff.net>
In-Reply-To
<d4ffe7fb-f782-4f06-9e3b-f72729d1e225@web.de>
On Tue, Jul 14, 2026 at 10:45:59AM +0200, René Scharfe wrote:
Show 10 quoted lines
> The HAVE_GETDELIM variant of strbuf_getwholeline() calls strbuf_reset()
> on the strbuf before handing it over to getdelim(3).  This is
> unnecessary:
> 
>   - getdelim(3) doesn't care whether the old buffer contents is
>     NUL-terminated and has no access to ->len,
>   - on success getdelim(3) NUL-terminates the buffer and we set ->len,
>   - on error we either call strbuf_init() or strbuf_reset().
> 
> Remove the superfluous preparatory call.

Good catch. In the original version of strbuf_getwholeline() we were missing that reset on error, which is why this was included. I think it became redundant in b70904306f (strbuf_getwholeline: NUL-terminate getdelim buffer on error, 2016-03-05).

-Peff
Previous: Junio C Hamano
Message 3 of 3 in “strbuf: avoid redundant reset in strbuf_getwholeline()”
  1. strbuf: avoid redundant reset in strbuf_getwholeline()René Scharfe, Jul 14, 2026
  2. Junio C HamanoJul 14, 2026
  3. Jeff KingJul 14, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.