Re: [PATCH] meson: wire up USE_NSEC build knob
- From
Jeff King <peff@peff.net>
- Date
- Jul 7, 2026, 04:38 UTC
- Message-ID
- <20260707043850.GC677056@coredump.intra.peff.net>
- In-Reply-To
- <aktOn-3K41Uhl9cr@pks.im>
On Mon, Jul 06, 2026 at 08:43:43AM +0200, Patrick Steinhardt wrote:
Show 10 quoted lines
> > To summarize: If we're all leaning in the direction of a run-time flag > > instead, I can noodle in that direction. That certainly involves a bit > > more surgery than just giving Meson access to the option, but the > > dynamism may be nice. I'm not too sure how we'd write a test case for > > it, though. > > I don't think we'd necessarily need a way to detect this. Our current > build default is to have this disabled, so I'd keep it this way, but > automatically compile nsec-support into Git if available. And then we > provide a way for users to opt-in to the new behaviour via the config.
Yeah, agreed. Even if we eventually auto-detect, the first step is adding the config at all. And then we can decide whether to stop there or not.
I'm agnostic on whether we add USE_NSEC to meson in the meantime, if it might eventually be ripped out of the Makefile. We _could_ retain USE_NSEC to change the unconfigured default for a given build, but I'd be inclined to just remove it entirely once the runtime config is available.
-Peff