git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/9] http: discard hash in dumb-http http_object_request

From
Jeff King <peff@peff.net>
Date
Jul 6, 2026, 00:44 UTC
Message-ID
<20260706004401.GA2308672@coredump.intra.peff.net>
In-Reply-To
<20260706000105.GA2301945@coredump.intra.peff.net>
On Sun, Jul 05, 2026 at 08:01:05PM -0400, Jeff King wrote:
Show 9 quoted lines
> That by itself is enough to make:
> 
>   algo->init_fn(&ctx);
>   git_hash_update(&ctx, ...);
>   git_hash_final(out, &ctx);
>   ...
>   git_hash_discard(&ctx);
> 
> safe.

Actually, that's not quite true. Setting the active flag happens in git_hash_init() in that model. But many callers use algo->init_fn() directly instead. They'd all need to be adjusted to use git_hash_init(). I don't think there's any reason they should avoid it, and it's mostly from inertia that they use the bare function pointer.

-Peff
Previous: Jeff KingNext: Patrick Steinhardt
Message 17 of 20 in “hash algorithm leak fixes”
  1. 0/9 hash algorithm leak fixesJeff King, Jul 2, 2026
  2. 1/9 csum-file: drop discard_hashfile()Jeff King, Jul 2, 2026
  3. Junio C HamanoJul 2, 2026
  4. Jeff KingJul 2, 2026
  5. Patrick SteinhardtJul 3, 2026
  6. 2/9 hash: add discard primitiveJeff King, Jul 2, 2026
  7. Patrick SteinhardtJul 3, 2026
  8. 3/9 csum-file: always finalize or discard hashJeff King, Jul 2, 2026
  9. 4/9 csum-file: provide a function to release checkpointsJeff King, Jul 2, 2026
  10. Patrick SteinhardtJul 3, 2026
  11. 5/9 patch-id: discard hash when doneJeff King, Jul 2, 2026
  12. 6/9 check_stream_oid(): discard hash on read errorJeff King, Jul 2, 2026
  13. 7/9 http: discard hash in dumb-http http_object_requestJeff King, Jul 2, 2026
  14. Patrick SteinhardtJul 3, 2026
  15. brian m. carlsonJul 3, 2026
  16. Jeff KingJul 6, 2026
  17. Jeff KingJul 6, 2026
  18. Patrick SteinhardtJul 6, 2026
  19. 8/9 hash: fix memory leak copying sha256 gcrypt handlesJeff King, Jul 2, 2026
  20. 9/9 hash: add platform-specific discard functionsJeff King, Jul 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.