git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/9] t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_64BIT

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 6, 2026, 06:23 UTC
Message-ID
<20260706-b4-pks-t-fixes-for-GIT-TEST-LONG-v3-2-4f6c5a37fd1f@pks.im>
In-Reply-To
<20260706-b4-pks-t-fixes-for-GIT-TEST-LONG-v3-0-4f6c5a37fd1f@pks.im>

One of the tests in t0021 writes a 2GB file and then roundtrips it through the clean/sumdge filters. This test is broken on 32 bit platforms because they typically don't handle files larger then `SSIZE_MAX` well at all.

While our CI has a "linux32" job that should in theory hit this issue, we never noticed it because we didn't use to run EXPENSIVE tests until 7a094d68a2 (ci: run expensive tests on push builds to integration branches, 2026-05-08). And after that commit, the test does not fail but instead hangs completely.

Ideally, we'd of course properly detect this situation and then test for it. In practice, this turns out to be hard as the test failure are not reliable as they often (but not always) run into ENOMEM errors.

Instead, skip the test altogether.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 t/t0021-conversion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
index 033b00a364..7b9a0ca877 100755
--- a/t/t0021-conversion.sh
+++ b/t/t0021-conversion.sh
@@ -296,7 +296,7 @@ test_expect_success 'filter that does not read is fine' '
 	test_cmp expect actual
 '
 
-test_expect_success EXPENSIVE 'filter large file' '
+test_expect_success EXPENSIVE,SIZE_T_IS_64BIT 'filter large file' '
 	test_config filter.largefile.smudge cat &&
 	test_config filter.largefile.clean cat &&
 	test_seq -f "%1048576d" 1 2048 >2GB &&
-- 
2.55.0.795.g602f6c329a.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 3 of 12 in “t: fixes and improvements for GIT_TEST_LONG”
  1. 0/9 t: fixes and improvements for GIT_TEST_LONGPatrick Steinhardt, Jul 6, 2026
  2. 1/9 README: add GitLab CI badge to make it more discoverablePatrick Steinhardt, Jul 6, 2026
  3. 2/9 t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_64BITPatrick Steinhardt, Jul 6, 2026
  4. 3/9 t4141: fix inefficient use of dd(1)Patrick Steinhardt, Jul 6, 2026
  5. 4/9 t5608: reduce maximum disk usagePatrick Steinhardt, Jul 6, 2026
  6. 5/9 t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_64BITPatrick Steinhardt, Jul 6, 2026
  7. 6/9 t7900: clean up large EXPENSIVE repositoryPatrick Steinhardt, Jul 6, 2026
  8. 7/9 t: use `test_bool_env` to parse GIT_TEST_LONGPatrick Steinhardt, Jul 6, 2026
  9. 8/9 gitlab-ci: disable RAM disk on macOS jobsPatrick Steinhardt, Jul 6, 2026
  10. 9/9 gitlab-ci: enable "GIT_TEST_LONG"Patrick Steinhardt, Jul 6, 2026
  11. Junio C HamanoJul 6, 2026
  12. Jeff KingJul 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.