git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/1] move excludes_file into repo_config_values

From
Tian Yuchen <cat@malon.dev>
Date
Jun 27, 2026, 15:45 UTC
Message-ID
<20260627154514.1073154-1-cat@malon.dev>

This patch continues the libification effort by migrating the global string variable 'excludes_file' into 'struct repo_config_values'. Since this is a dynamically allocated variable, the migration requires proper heap memory management.

This patch mainly does three things:
 - Abstract the XDG fallback lazy-loading logic out of dir.c into a proper
 getter.
 - Move the variables into the struct repo_config_values.
 - Introduce the memory destructor 'repo_config_values_clear()'.
Changes since V2:
 - Squash together the previous two commits into one.
 - The 'repo->initialized' check is used in both the getter and destructor.
 This eliminates redundant checks and follows the fail-fast principle. This
 is consistent with the previous global variable removal patches [1][2][3].
Thanks!
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
Signed-off-by: Tian Yuchen <cat@malon.dev>

[1] https://lore.kernel.org/git/20260610093635.139719-1-cat@malon.dev/T/#m856253610936d052a798259bfc06d598561e53c4 [2] https://lore.kernel.org/git/20260606143412.15443-1-cat@malon.dev/ [3] https://lore.kernel.org/git/20260617154929.564498-2-cat@malon.dev/T/#m8843984a6175a1a4c7e00877085c77b0c72f5803

Tian Yuchen (1):
  environment: move excludes_file into repo_config_values
 dir.c         |  4 ++--
 environment.c | 30 +++++++++++++++++++++++++++---
 environment.h | 13 ++++++++++++-
 repository.c  |  1 +
 4 files changed, 42 insertions(+), 6 deletions(-)
-- 
2.43.0
Next: Tian Yuchen
Message 1 of 3 in “move excludes_file into repo_config_values”
  1. 0/1 move excludes_file into repo_config_valuesTian Yuchen, Jun 27, 2026
  2. 1/1 environment: move excludes_file into repo_config_valuesTian Yuchen, Jun 27, 2026
  3. Tian YuchenJun 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.