git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3420-rebase-autostash: don't try to grep non-existing files

From
Todd Zullinger <tmz@pobox.com>
Date
Jun 27, 2026, 14:27 UTC
Message-ID
<20260627142728.0BU3FFok@teonanacatl.net>
In-Reply-To
<aj90x3DsER5HASUS@szeder.dev>
SZEDER Gábor wrote:
Show 14 quoted lines
> On Sun, Oct 10, 2021 at 07:28:09PM +0200, SZEDER Gábor wrote:
>> Several tests in 't3420-rebase-autostash.sh' start various rebase
>> processes that are expected to fail because of merge conflicts.  The
>> tests [1] checking that 'git rebase --quit' and autostash work
>> together as expected after such a failure then run '! grep ...' to
>> ensure that the dirty contents of the file is gone.  However, due to
>> the test repo's history and the choice of upstream branch that file
>> shouldn't exist in the conflicted state at all, and thus it shouldn't
>> exist after the subsequent 'git rebase --quit' either.  Consequently,
>> this 'grep' doesn't fail as expected, i.e. because it can't find the
>> dirty content, but instead it fails, because it can't open the file.
>> 
>> Thighten this check by using 'test_path_is_missing' instead, thereby
>> avoiding unexpected errors from 'grep' as well.
Thighten -> Tighten
-- 
Todd
Previous: Phillip WoodNext: Junio C Hamano
Message 4 of 5 in “t3420-rebase-autostash: don't try to grep non-existing files”
  1. t3420-rebase-autostash: don't try to grep non-existing filesSZEDER Gábor, Oct 10, 2021
  2. SZEDER GáborJun 27, 2026
  3. Phillip WoodJun 27, 2026
  4. Todd ZullingerJun 27, 2026
  5. Junio C HamanoJun 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.