git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4216: fix no-op test that breaks TAP output

From
Todd Zullinger <tmz@pobox.com>
Date
Jun 25, 2026, 18:51 UTC
Message-ID
<20260625185112.jjH0K9LI@teonanacatl.net>
In-Reply-To
<ajjBmi39IFJW5p5V@pks.im>
Patrick Steinhardt wrote:
Show 15 quoted lines
> On Fri, Jun 19, 2026 at 09:29:44AM -0700, Junio C Hamano wrote:
>> Taylor Blau <me@ttaylorr.com> writes:
>> 
>>> Given this and the above, I would probably err on the side of
>>> designating this as 'test_lazy_prereq' or otherwise silencing the output
>>> of 'test_cmp' so that this does not taint the TAP output.
>> 
>> We can argue the merit and demerit with a good log message.  The
>> central issue at hand is how precious 52a9 in the script lost by
>> this patch is (in other words, are we checking more than "is our
>> char signed or unsigned?").
> 
> Ultimately, I don't mind much which way we go. But if we want to retain
> this, would you mind sending a rewritten v2, Taylor? I feel like you're
> in a better position to argue why we should retain it.

Is this something which can be merged before 2.55.0 final? It's certainly not a grave issue, but it is a new test failure for anyone who diligently runs the test suite on many (most?) non-x86 architectures. It seems a shame to punish those folks. :)

FWIW, Tested-by: Todd Zullinger <tmz@pobox.com>
I tested the earlier test_lazy_prereq version as well.
-- 
Todd
Previous: Patrick SteinhardtNext: Junio C Hamano
Message 5 of 6 in “t4216: fix no-op test that breaks TAP output”
  1. t4216: fix no-op test that breaks TAP outputPatrick Steinhardt, Jun 19, 2026
  2. Taylor BlauJun 19, 2026
  3. Junio C HamanoJun 19, 2026
  4. Patrick SteinhardtJun 22, 2026
  5. Todd ZullingerJun 25, 2026
  6. Junio C HamanoJun 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.