[PATCH v1 0/2] environment: move excludes_file into repo_config_values
- From
Tian Yuchen <cat@malon.dev>
- Date
- Jun 25, 2026, 16:18 UTC
- Message-ID
- <20260625161845.7543-1-cat@malon.dev>
This series continues the libification effort by migrating the global string variable 'excludes_file' into 'struct repo_config_values'. Since this is a dynamically allocated variable, the migration requires proper heap memory management.
The series is structured in two commits:
- Abstract the XDG fallback lazy-loading logic out of dir.c into a proper getter.
- Move the variable into the struct and introducs 'repo_config_values_clear()'.
Note on Submodules: A temporary shield 'if (repo != the_repository)' is included in both the getter and the clear function. This prevents uninitialized submodules from triggering the BUG() assertion. (Inspiration: [1])
Thanks.
Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com> Signed-off-by: Tian Yuchen <cat@malon.dev>
[1] https://lore.kernel.org/git/c95a7730-7b14-4be0-a4e4-861b2f5430ea@gmail.com/
Tian Yuchen (2): dir: encapsulate excludes_file lazy-load environment: move excludes_file into repo_config_values
dir.c | 4 ++-- environment.c | 29 ++++++++++++++++++++++++++--- environment.h | 14 +++++++++++++- repository.c | 1 + 4 files changed, 42 insertions(+), 6 deletions(-)
-- 2.43.0